Import copy fastpath #1197
Closed
Import copy fastpath #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Sep 21, 2017
|
|
||
| if (!_ostree_repo_ensure_loose_objdir_at (self->objects_dir_fd, loose_path_buf, cancellable, error)) | ||
| return FALSE; | ||
| /* This is yet another variation of glnx_file_copy_at() |
There was a problem hiding this comment.
I'm confused, if it's a bare file, we have to chown, right? (Well, unless we're running as the id of the source object, which is probably an optimization we should teach to glnx_file_copy_at).
There was a problem hiding this comment.
Yep, realized that after submitting. Will fix soon.
There was a problem hiding this comment.
(To clarify we only need to chown for bare repos)
|
☔ The latest upstream changes (presumably d75316c) made this pull request unmergeable. Please resolve the merge conflicts. |
This fixes up the last of the embarassing bits I saw from the stack trace in: ostreedev#1184 We had a hardlink fast path, but that doesn't apply across devices, which occurs in two notable cases: - Installer ISO with local repo - Tools like pungi that copy the repo to a local snapshot Obviously there are a lot of subtleties here around things like the bare-user-only conversions as well as exactly what data we copy. I think to get better test coverage we may want to add `pull-local --no-hardlink` or so.
cgwalters
force-pushed
the
import-copy-fastpath
branch
from
cd262a6 to
e9d7273
Compare
|
bot, retest this please |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the copy fastpath bit out from #1193